Skip to content

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Oct 2, 2025

Part of WOOMOB-935

Just one review is required.

Description

This PR moves shared image assets used by both the main app and POS to the WooFoundation module, consolidating them in preparation for POS modularization (#16176).

Key Changes:

  • Created SharedImageAsset enum in WooFoundation with standardized SwiftUI Image and UIImage access
  • Moved 5 shared image assets from main app to WooFoundation:
    • card-reader-update-progress-arrow and card-reader-update-progress-checkmark (used in reader update progress)
    • coupons (used in empty states)
    • location (used in reader connection alerts)
    • shopping-bags (used in cart empty state)
  • Updated main app to use SharedImageAsset instead of direct image names
  • Replaced POS-specific UIImage+POS.swift extension with SharedImageAsset usage
  • Updated POS views to use SharedImageAsset for consistent image access

Benefits:

  • Eliminates image duplication between app and POS module
  • Provides type-safe image access through enum cases
  • Centralizes shared resources in WooFoundation for easier maintenance
  • Reduces coupling between POS and main app resources

Steps to reproduce

A quick regression test in POS would be helpful:

  1. Build and run the app on an iPad
  2. Navigate to POS
  3. Verify the following images display correctly:
    • Empty cart shows shopping bags icon
    • Empty coupons list shows coupons icon
    • Card reader connection location alerts show location icon
    • Card reader update progress shows arrow/checkmark icons

Testing information

I tested the following scenarios on iPad A16 iOS 26.0 simulator, and SwiftUI previews in Xcode 26.

column 1 column 2
Screenshot 2025-10-02 at 10 41 45 AM Screenshot 2025-10-02 at 10 45 19 AM
Screenshot 2025-10-02 at 10 46 15 AM Screenshot 2025-10-02 at 10 46 40 AM
Simulator Screenshot - iPad (A16) - 2025-10-02 at 10 39 50 Simulator Screenshot - iPad (A16) - 2025-10-02 at 10 44 11

Card reader software update:

Simulator.Screen.Recording.-.iPad.A16.-.2025-10-02.at.10.56.29.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 2, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@jaclync jaclync added this to the 23.4 milestone Oct 2, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16194-90ac9dc
Version23.3
Bundle IDcom.automattic.alpha.woocommerce
Commit90ac9dc
Installation URL7i7f6uvkhjlfo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested on a device: iPad Air M2 26.0, all these images appear well.

@jaclync jaclync merged commit 2ba70b0 into trunk Oct 3, 2025
19 checks passed
@jaclync jaclync deleted the feat/WOOMOB-935-move-shared-image-assets-to-WooFoundation branch October 3, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants